AI junk#3667
Closed
sean-kim05 wants to merge 1 commit into
Closed
Conversation
The 'try a binary write, then fall back to a text write' probe in
`_FixupStream.writable()` had both branches writing `b""`, so the text
fallback was dead: a writable text stream that lacks a native `writable()`
method (the 'badly patched objects on sys' case the class exists for) was
reported as not writable.
The primary probe was changed from `write("")` to `write(b"")` in a 2024
type-cleanup (fde47b4) without updating the fallback. Restore the fallback to
a text write, matching the sibling `_is_binary_writer` helper which probes
`write(b"")` then `write("")`.
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'try a binary write, then fall back to a text write' probe in
_FixupStream.writable()had both branches writingb"", so the text fallback was dead: a writable text stream that lacks a nativewritable()method (the 'badly patched objects on sys' case the class exists for) was reported as not writable.The primary probe was changed from
write("")towrite(b"")in a 2024 type-cleanup (fde47b4) without updating the fallback. Restore the fallback to a text write, matching the sibling_is_binary_writerhelper which probeswrite(b"")thenwrite("").