AI spam#3668
Closed
Hasnaathussain wants to merge 1 commit into
Closed
Conversation
When update_min_steps is specified and not a divisor of the total length, the progress bar completion state (such as the item position fraction show_pos) remains undercounted because the final updates are discarded. Flushing any trailing completed steps ensures the progress bar shows full completion upon finishing.
ThiefMaster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
update_min_stepsis configured with a value that is not a divisor of the progress bar's totallength, any remaining updates at the end that are fewer thanupdate_min_stepsare not flushed toself.pos. Whenshow_pos=True, this leaves the final display at less than the total count (e.g.14/20instead of20/20), even thoughself.finishedbecomes True and percentage shows100%.This PR updates the
finishmethod ofProgressBarto flush any remaining uncompleted intervals toself.posby callingmake_step().A regression test has been added to
tests/test_termui.py.