AI junk#6078
Closed
ishaanlabs-gg wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the monkeypatch module's current sentinel name instead of importing the removed
_pytest.monkeypatch.notsetsymbol directly.Pytest 9.1 exposes the sentinel as
_pytest.monkeypatch.NOTSET, while pytest 9.0 still uses_pytest.monkeypatch.notset. This keeps the existing monkeypatch bookkeeping behavior on both versions, while allowing Flask's tests to collect and run with pytest 9.1.This also keeps
CertParamTypegeneric for static type checkers while avoiding runtime subscripting ofclick.ParamTypeon older supported Click versions, and avoids Werkzeug main deprecation warnings in tests by preferring the newer datastructure parsing helpers when they are available.fixes #6071
Validation:
python -m pytest tests -qpython -m pytest tests -qpython -m mypypyright --pythonpath <venv>/bin/pythonpython -m py_compile src/flask/cli.py tests/conftest.py tests/test_cli.py tests/test_blueprints.py tests/test_views.pypython -m ruff check src/flask/cli.py tests/conftest.py tests/test_cli.py tests/test_blueprints.py tests/test_views.pygit diff --check