Skip to content

refactor: Bump cross-env from 7.0.3 to 10.1.0 #10579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrezza merged 1 commit into from
Jul 16, 2026
+28 −15
Merged

refactor: Bump cross-env from 7.0.3 to 10.1.0 #10579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"all-node-versions": "13.0.1",
"apollo-upload-client": "18.0.1",
"clean-jsdoc-theme": "4.3.0",
"cross-env": "7.0.3",
"cross-env": "10.1.0",

@coderabbitai coderabbitai Bot Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -eu

rg -n -C 8 \
  '(node-version|npm (ci|install|run)|cross-env|engine-strict)' \
  .github/workflows/release-manual-docs.yml package.json .npmrc 2>/dev/null || true

Repository: parse-community/parse-server

Length of output: 6312

🏁 Script executed:

#!/bin/bash
set -eu

echo "== release-manual-docs workflow =="
cat -n .github/workflows/release-manual-docs.yml

echo
echo "== release_docs.sh =="
if [ -f release_docs.sh ]; then
  cat -n release_docs.sh
fi

echo
echo "== package.json engines/scripts around docs =="
cat -n package.json | sed -n '110,150p'

Repository: parse-community/parse-server

Length of output: 6436

Update the manual docs workflow to Node 20+. .github/workflows/release-manual-docs.yml still pins node-version: 18.20.4, but that job runs npm ci and ./release_docs.sh, so it will hit the repo’s Node 20+ toolchain requirements and can break docs releases.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 85, Update the node-version setting in the manual docs
workflow to Node 20 or newer, ensuring the job running npm ci and
release_docs.sh uses the repository’s supported toolchain. Keep the existing
workflow behavior unchanged.

@mtrezza mtrezza Jul 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid observation, but out of scope for this cross-env devDependency bump. The Node 18.20.4 pin in release-manual-docs.yml is a pre-existing inconsistency (the repo already requires engines.node >=20.19.0 independently of this PR); there is no engine-strict, so a Node mismatch only emits an EBADENGINE warning rather than failing; and per our dependency-update policy, CI/engine Node versions are not modified as part of a dependency bump. Tracking the docs-workflow Node bump as a separate change.

@coderabbitai coderabbitai Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtrezza, acknowledged. The workflow mismatch is pre-existing and, given the stated dependency-update policy plus the absence of engine-strict, it should not expand this dependency-only PR. I’ll treat this review item as non-blocking.

If a follow-up has not already been created, would you like me to open a GitHub issue for updating .github/workflows/release-manual-docs.yml to a supported Node version?

✏️ Learnings added 
Learnt from: mtrezza
Repo: parse-community/parse-server PR: 10579
File: package.json:85-85
Timestamp: 2026-07-16T20:01:25.043Z
Learning: For parse-community/parse-server dependency-update pull requests, do not modify CI or Node engine versions as part of the dependency bump; pre-existing toolchain inconsistencies must be tracked separately.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

"deep-diff": "1.0.2",
"eslint": "9.27.0",
"eslint-plugin-expect-type": "0.6.2",
Expand Down
Loading