feat(misc): separate CSSVariables into its own tab - #5046
Conversation
|
Some pages on org are so slow and this PR improves them quite a bit. A before/after of DOM nodes for a few components pages that are particularly slow
|
rebeccaalpert
left a comment
There was a problem hiding this comment.
This looks good to me.
For pages with more than one table like http://localhost:8003/components/alert/css-variables, we may want to add a TOC or something so it's easier to see, but that's a scope increase here.
mcoker
left a comment
There was a problem hiding this comment.
I'm noticing extra filter boxes on some components. Looks like it's referencing the cssPrefix metadata in example files to build the table from? If so, we could just go through our example files and fix ones with incorrect values, and/or we could exclude the heading/table if the table is empty.
https://pf-org--pr-5046-site.surge.sh/components/button/css-variables#prefixed-with-pf-d-button
https://pf-org--pr-5046-site.surge.sh/components/table/css-variables#prefixed-with-pf-c-table
Authored by Cursor AI, pending more review for cleanliness