Add file-like interface to Material for openmc Evaluation compatibility#40
Closed
shimwell wants to merge 1 commit into
Closed
Add file-like interface to Material for openmc Evaluation compatibility#40shimwell wants to merge 1 commit into
shimwell wants to merge 1 commit into
Conversation
Contributor
Author
|
this issue #39 surfaced again today, any chance of merging this |
5 tasks
Owner
|
Closing since openmc-dev/openmc#3932 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change fixes issue #39 for me.
openmc.data.endf imports get_materials as get_evaluations, so code that calls get_evaluations() receives Material objects.
However, openmc.data.IncidentPhoton.from_endf() only recognizes its own Evaluation type via isinstance, and falls back to Evaluation(obj) which expects a file-like object. This fails with AttributeError: 'Material' object has no attribute 'tell'.
This PR adds tell(), readline(), and seek() methods to Material that delegate to a lazily-built StringIO reconstructing valid ENDF text from section_text. This allows Material to be passed anywhere a file-like ENDF source is expected.