Fix Python 3.14 asyncio event loop compatibility#155
Open
BinaryHusk wants to merge 1 commit intopedroCabrera:masterfrom
Open
Fix Python 3.14 asyncio event loop compatibility#155BinaryHusk wants to merge 1 commit intopedroCabrera:masterfrom
BinaryHusk wants to merge 1 commit intopedroCabrera:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Python 3.14 support in the standalone editor after
asyncio.get_event_loop()changed behavior in Python 3.14.This updates the editor tick path and
subProcessnode task creation, and adds a regression test for both cases.Problem
According to the Python 3.14 event loop documentation,
asyncio.get_event_loop()now raisesRuntimeErrorif there is no current event loop.PyFlow still relied on the old behavior in:
PyFlow/App.pyPyFlow/Packages/PyFlowBase/Nodes/subProcess.pyThat caused standalone startup to fail with:
RuntimeError: There is no current event loop in thread 'MainThread'Fix
PyFlow/Core/AsyncLoop.pyPyFlow/App.pyso the standalone editor tick no longer depends onasyncio.get_event_loop()PyFlow/Packages/PyFlowBase/Nodes/subProcess.pywhen creating async taskssubProcesspath are both checkedCompatibility
Verified on Python 3.9 through 3.14.
Existing tests pass, and the standalone editor no longer hits the repeated event loop error on Python 3.14.