fix: Prevent initial create project dialog from being persistent#2785
Closed
aryanjsingh wants to merge 1 commit intophcode-dev:mainfrom
Closed
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "show on startup" setting for the initial project dialog was not being respected. This was due to a race condition in StateManager where settings changed before the state file was fully loaded were being overwritten. This change ensures that the loaded state is merged with the current in-memory state, preserving any changes.
Changes
StateManager.js. When loading the state file from disk, it would overwrite any in-memory state that had been set before the file read completed. The fix is to merge the loaded data with the in-memory data using_.extend, which preserves any settings that were changed during the loading process.Related Issue
Closes #2763