fix(worker): incorrect session state

[xavierleune]

• Conditionaly include ext/session/php_session
• Simpler session management without handler snapshot

[dunglas]

What's the difference with #2192? #2192 looks simpler.

[xavierleune]

What's the difference with #2192? #2192 looks simpler.

I remove session from MODULES_TO_RELOAD but destroy session data, leaving handlers untouched to keep the bugfix from #2139

[AlliBalliBaba]

Looks a bit cleaner than the previous solution, you'll also have to add BC for PHP 8.2 https://github.com/php/frankenphp/actions/runs/22057186532/job/63728080602?pr=2193

Would also probably be nice to add tests that somewhat reproduce #2190 and #2185, since with this solution we'd have to keep up with changes in the session extension.

[xavierleune]

Thanks for the feedback. I'll try to have a small reproducer but was unable to so far. For the future I think we may propose a small change in php to expose a clean api to remove the need to follow upcoming changes. A small function with the subset reproduced here would do the trick.

[dunglas]

Could you please rebase to see if tests are green @xavierleune?

It would be nice if you could check the "allow maintainers to push code" checkbox so we could do that directly, btw :)

Thanks for your contribs!!

[xavierleune]

@dunglas i'll mark this one as draft for now. I've investigated more on #2185 and it seems to be unrelated to changes around session, but more to the ini reset. You can see this comment with more details.
I'll open a PR with a small reproducer for the bug, but I think we might need your input about the best way to fix it.

When the root cause with ini is fixed I'll continue on this PR