Skip to content

update incompatibilities section#2420

Open
henderkes wants to merge 1 commit into
mainfrom
docs/musl
Open

update incompatibilities section#2420
henderkes wants to merge 1 commit into
mainfrom
docs/musl

Conversation

@henderkes
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread docs/known-issues.md
| Name | Problem |
|---------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------|
| [datadog](https://github.com/DataDog) | Experiences instability when profiling FrankenPHP. This bug is [being tracked by DataDog](https://github.com/DataDog/dd-trace-php/issues/3729). |
| [blackfire](https://blackfire.io/) | [FrankenPHP support is in beta and not yet feature-complete](https://docs.blackfire.io/php/integrations/frankenphp). |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it shouldn't be marked as "buggy". It works perfectly well in normal mode.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of them? I've seen crashes for both not too recently

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blackfire. But if they both crash, then let's keep them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blackfire is using datadog for continuous profiling (ZTS) under the hood, so it might be related to that. Perhaps we can rename the header from "buggy" to something else, but I'm not sure to what.

Copy link
Copy Markdown
Contributor Author

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps like this?

Comment thread docs/known-issues.md
| [imap](https://www.php.net/manual/imap.installation.php) | Not thread-safe | [javanile/php-imap2](https://github.com/javanile/php-imap2), [webklex/php-imap](https://github.com/Webklex/php-imap), [ImapEngine](https://github.com/DirectoryTree/ImapEngine) |
| [newrelic](https://docs.newrelic.com/docs/apm/agents/php-agent/getting-started/introduction-new-relic-php/) | Not thread-safe | - |

## Buggy PHP extensions
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Buggy PHP extensions
## PHP extensions with limited support

Comment thread docs/known-issues.md

## Buggy PHP extensions

The following extensions have known bugs and unexpected behaviors when used with FrankenPHP:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following extensions have known bugs and unexpected behaviors when used with FrankenPHP:
The following extensions are in beta or have known issues when used with FrankenPHP:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants