ext/sockets: socket_addrinfo_lookup() allows AF_UNSPEC for ai_family. #20658
+26
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
socket_addrinfo_lookup
branch
from
ccc8401 to
bbf7fc6
Compare
Girgias
reviewed
Jan 13, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Looks reasonable but I don't really know sockets soooo.
Aside, I just noticed that the host parameter probably should be a Z_PARAM_STR_PATH as it is passed to getaddrinfo() without the length.
Comment on lines
2802
to
2826
| // Some platforms support also PF_LOCAL/AF_UNIX (e.g. FreeBSD) but the security concerns implied | ||
| // make it not worth handling it (e.g. unwarranted write permissions on the socket). | ||
| // Note existing socket_addrinfo* api already forbid such case. |
Member
There was a problem hiding this comment.
Does the comment need updating?
Member
Author
There was a problem hiding this comment.
no it s still true, we still want to deal with only AF_INET*
Member
Author
seems good point, I ll update soon. Cheers ! |
while still filtering out IPC like addresses and so on.
devnexen
force-pushed
the
socket_addrinfo_lookup
branch
from
bbf7fc6 to
5460bd0
Compare
Girgias
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while still filtering out IPC like addresses and so on.