Skip to content

streams/memory: Ensure internal string is NUL terminated #20812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ndossche wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
Open

streams/memory: Ensure internal string is NUL terminated #20812

ndossche wants to merge 1 commit into from
+1 −1

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Dec 30, 2025

zend_string_truncate() doesn't put a NUL byte.

@ndossche
streams/memory: Ensure internal string is NUL terminated
914804c 
zend_string_truncate() doesn't put a NUL byte.
@ndossche ndossche marked this pull request as ready for review December 31, 2025 10:18
@ndossche ndossche requested a review from bukka as a code owner December 31, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka bukka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndossche @bukka