Skip to content

ext/standard: Fix round() for large integral doubles #22411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshidkv12 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −0
Open

ext/standard: Fix round() for large integral doubles #22411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ext/standard/math.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ PHPAPI double _php_math_round(double value, int places, int mode) {
return value;
}

if (places == 0 && value == trunc(value)) {
return value;
}

places = places < INT_MIN+1 ? INT_MIN+1 : places;

exponent = php_intpow10(abs(places));
Expand Down
14 changes: 14 additions & 0 deletions ext/standard/tests/math/gh22410.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
--TEST--
gh-22410: round() preserves integral doubles
--FILE--
<?php
var_dump(round(1.0));
var_dump(round(-1.0));
var_dump(round((float) 9003241321073828));
var_dump(round((float) -9003241321073828));
?>
--EXPECT--
float(1)
float(-1)
float(9003241321073828)
float(-9003241321073828)
Loading