Skip to content

ext/gd: pack imageloadfont short-read test in native byte order #22416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+4 −2
Open

ext/gd: pack imageloadfont short-read test in native byte order #22416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ext/gd/tests/imageloadfont_short_read.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ gd
/* A user-space wrapper returns one byte per read, so php_stream_read() hands
* imageloadfont()'s header loop a short read on every iteration. The header
* (4 ints) plus a single 1x1 glyph byte form a valid font, which only loads
* when each short read lands at the correct byte offset. */
* when each short read lands at the correct byte offset. imageloadfont() reads
* the header as native-endian ints, so pack the fields with 'i' (not 'V') to
* keep the font valid on big-endian hosts too. */
class drip
{
public $context;
Expand All @@ -16,7 +18,7 @@ class drip

public function stream_open($path, $mode, $options, &$opened): bool
{
$this->data = pack('V4', 1, 32, 1, 1) . "\x00";
$this->data = pack('i4', 1, 32, 1, 1) . "\x00";
return true;
}

Expand Down
Loading