Skip to content

build/gen_stub: include attribute arguments in synopsis modifiers#22418

Open
jordikroon wants to merge 2 commits into
php:PHP-8.4from
jordikroon:gen-stub-attribute-args
Open

build/gen_stub: include attribute arguments in synopsis modifiers#22418
jordikroon wants to merge 2 commits into
php:PHP-8.4from
jordikroon:gen-stub-attribute-args

Conversation

@jordikroon

Copy link
Copy Markdown
Member

Output: php/doc-en#5631

@DanielEScherzer DanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output at php/doc-en#5631 looks good to me, leaving to mate for final approval

@jordikroon

Copy link
Copy Markdown
Member Author

Upon closely inspecting all files (php/doc-en@b782ece) I noticed 3 files had cvalues instead of their actual constant value.

Adding CloningVisitor seems to have fixed that, but I can't really fully judge it's impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants