zend_test: test ZPP specifiers - #23192
Open
Girgias wants to merge 9 commits into
Open
Conversation
arnaud-lb
reviewed
Aug 10, 2026
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
IMHO we shouldn't have tests at all in ext/zend_test, unless they are testing the extension itself. That's usually not the case: We call functions of ext/zend_test for the purpose of testing something else.
|
|
||
| $types = require 'types.inc'; | ||
|
|
||
| foreach ($types as $type) { |
Member
There was a problem hiding this comment.
Please print something between each loop, and maybe before each try/catch block below, so that we can identify what the output relates to. This helps a lot when debugging a regression, or just when reviewing the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ZPP tests from Zend/ to zend_test/ and add tests for the bool/int/float/number ZPP specifiers.
We don't test ZPP in normal functional tests, but it should still be tested somewhere.
Obviously there are many specifiers meaning:
array|object,object|class-string,object|int,array|string,strint|int)