-
Notifications
You must be signed in to change notification settings - Fork 613
license-update: update website with new license info #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🚀 Preview for commit 2c14ed2 can be found at https://web-php-pr-1762.preview.thephp.foundation |
|
🚀 Regression report for commit 2c14ed2 is at https://web-php-regression-report-pr-1762.preview.thephp.foundation |
| <li><a href="http://pecl.php.net/copyright.php">PECL</a></li> | ||
| <li><a href="http://pear.php.net/copyright.php">PEAR</a></li> | ||
| <li><a href="https://pecl.php.net/copyright.php">PECL</a></li> | ||
| <li><a href="https://pear.php.net/copyright.php">PEAR</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PEAR server might possibly no longer exist by this Friday, and maybe we should just remove this section now? PECL also does no longer accept new packages either.
| This ensures that the license information can be read properly even when a | ||
| binary is shipped instead of source code. A text file containing license and | ||
| copyright information is sometimes given the filename "Notice" or "NOTICE," | ||
| and may be referred to as a "notice file." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The , in "NOTICE," and the . in "notice file." should be outside the "'s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those silly American style guides! 😉
I generally follow the MLA style guide in writing, but the APA style guide and AP stylebook also agree that commas and periods should be placed inside closing quotation marks.
However, I'm aware that British English generally places them outside closing quotation marks. Is it the style of php.net to follow the British style?
This PR encompasses the changes proposed in the PHP License Update RFC, for the PHP website.
Discussion is available on the internals mailing list.
Changes proposed for php-src are available at php/php-src#20904.