Validator can approve or deny using the queue’s robot - #418
Conversation
d979b74 to
8682ef1
Compare
b2df706 to
c51d94a
Compare
There was a problem hiding this comment.
Pull request overview
Updates the validation (approve/deny) workflow so queue actions can be posted under the queue’s configured robot account by default, with an option for validators to post as themselves.
Changes:
- Added a “post as” radio option to the approve/deny confirmation form when a robot is available.
- Introduced new language strings for “Approve as / Deny as / Yourself”.
- Extended queue posting/notification methods to support an optional poster/sender user ID (robot).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| styles/prosilver/template/manage/queue_validate.html | Adds UI controls (radio buttons) to choose whether to post as the robot or as the validator. |
| language/en/manage.php | Adds English labels for the new “post as” UI. |
| includes/objects/queue.php | Threads an optional user ID through queue replies, release-topic replies, and approve/deny PM notifications. |
| controller/manage/queue/item.php | Reads the new form field, decides whether to use the contribution type’s robot user ID, and supplies template vars for the UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Tested on a local board, all works: robot default, the Yourself option, and the fallback when the robot user does not exist. One note: nothing records which validator approved or denied an item once the robot posts the reply, since there is no log entry or validated_by field. Maybe log the acting user on approve and deny. |
Queue approvals and denials now post as the queue robot account by default for consistency (if the robot exists), with validators able to optionally choose to post under their own username via a radio button on the approval/denial form.