Prevent Scalar expressions to be specified

[staabm]

before this change a call to match(1) would specify a expression $scope->expressionTypes[1] (integer key).
we expect this array to be keyed with string types though:

phpstan-src/src/Analyser/MutatingScope.php

Line 200 in 21a1602

* @param array<string, ExpressionTypeHolder> $expressionTypes

In addition literal const scalar values do not make sense to be specified in scope.. it does not provide more information

found in snippet:

<?php declare(strict_types = 1); // lint >= 8.1

namespace Bug10418;

use function PHPStan\debugScope;

function (): void {
	$text = '123';
	$result = match(1){
		preg_match('/(\d+)/', $text, $match) => 'matched number: ' . $match[1],
		preg_match('/(\w+)/', $text, $match) => 'matched word: ' . json_encode($match),
		default => 'no matches!'
	};
	debugScope();
};

[ondrejmirtes]

A similar skip could be done in TypeSpecifier::createForExpr as well.

[ondrejmirtes]

Thank you!

[ondrejmirtes]

The TypeSpecifier idea doesn't work, sometimes we have to report things like is_numeric('blabla') is always false.