Fix phpstan/phpstan#11619: Parameter #2 $callback of function uasort expects callable(Foo, Foo): int, 'strnatcasecmp' given.

src/Reflection/Callables/CallableParametersAcceptor.php

@@ -60,4 +60,6 @@ public function mustUseReturnValue(): TrinaryLogic;
 
 	public function getAsserts(): Assertions;
 
+	public function isBuiltin(): TrinaryLogic;
+
 }

src/Reflection/Callables/FunctionCallableVariant.php

@@ -179,4 +179,14 @@ public function getAsserts(): Assertions
 		return $this->function->getAsserts();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		$isBuiltin = $this->function->isBuiltin();
+		if ($isBuiltin instanceof TrinaryLogic) {
+			return $isBuiltin;
+		}
+
+		return TrinaryLogic::createFromBoolean($isBuiltin);
+	}
+
 }

src/Reflection/ExtendedCallableFunctionVariant.php

@@ -37,6 +37,7 @@ public function __construct(
 		private array $usedVariables,
 		private TrinaryLogic $acceptsNamedArguments,
 		private TrinaryLogic $mustUseReturnValue,
+		private TrinaryLogic $isBuiltinCallable,
 		private ?Assertions $assertions = null,
 	)
 	{
@@ -92,4 +93,9 @@ public function getAsserts(): Assertions
 		return $this->assertions ?? Assertions::createEmpty();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return $this->isBuiltinCallable;
+	}
+
 }

src/Reflection/GenericParametersAcceptorResolver.php

@@ -130,6 +130,7 @@ public static function resolve(array $argTypes, ParametersAcceptor $parametersAc
 				$originalParametersAcceptor->getUsedVariables(),
 				$originalParametersAcceptor->acceptsNamedArguments(),
 				$originalParametersAcceptor->mustUseReturnValue(),
+				$originalParametersAcceptor->isBuiltin(),
 				$originalParametersAcceptor->getAsserts(),
 			);
 		}

src/Reflection/InaccessibleMethod.php

@@ -98,4 +98,9 @@ public function getAsserts(): Assertions
 		return Assertions::createEmpty();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 }

src/Reflection/ParametersAcceptorSelector.php

@@ -736,6 +736,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
 		$usedVariables = [];
 		$acceptsNamedArguments = TrinaryLogic::createNo();
 		$mustUseReturnValue = TrinaryLogic::createMaybe();
+		$isBuiltin = TrinaryLogic::createMaybe();
 
 		foreach ($acceptors as $acceptor) {
 			$returnTypes[] = $acceptor->getReturnType();
@@ -753,6 +754,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
 				$usedVariables = array_merge($usedVariables, $acceptor->getUsedVariables());
 				$acceptsNamedArguments = $acceptsNamedArguments->or($acceptor->acceptsNamedArguments());
 				$mustUseReturnValue = $mustUseReturnValue->or($acceptor->mustUseReturnValue());
+				$isBuiltin = $isBuiltin->or($acceptor->isBuiltin());
 			}
 			$isVariadic = $isVariadic || $acceptor->isVariadic();
 
@@ -860,6 +862,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
 				$usedVariables,
 				$acceptsNamedArguments,
 				$mustUseReturnValue,
+				$isBuiltin,
 			);
 		}
 
@@ -897,6 +900,7 @@ private static function wrapAcceptor(ParametersAcceptor $acceptor): ExtendedPara
 				$acceptor->getUsedVariables(),
 				$acceptor->acceptsNamedArguments(),
 				$acceptor->mustUseReturnValue(),
+				$acceptor->isBuiltin(),
 				$acceptor->getAsserts(),
 			);
 		}

src/Reflection/ResolvedFunctionVariantWithCallable.php

@@ -29,6 +29,7 @@ public function __construct(
 		private array $usedVariables,
 		private TrinaryLogic $acceptsNamedArguments,
 		private TrinaryLogic $mustUseReturnValue,
+		private TrinaryLogic $isBuiltinCallable,
 		private ?Assertions $assertions = null,
 	)
 	{
@@ -124,4 +125,9 @@ public function getAsserts(): Assertions
 		return $this->assertions ?? Assertions::createEmpty();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return $this->isBuiltinCallable;
+	}
+
 }

src/Reflection/TrivialParametersAcceptor.php

@@ -108,4 +108,9 @@ public function getAsserts(): Assertions
 		return Assertions::createEmpty();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 }

src/Type/CallableType.php

@@ -180,11 +180,12 @@ private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny): IsSup
 
 		$variantsResult = null;
 		foreach ($type->getCallableParametersAcceptors($scope) as $variant) {
+			$isBuiltinCallable = $variant->isBuiltin()->yes();
 			$variant = ParametersAcceptorSelector::selectFromTypes($parameterTypes, [$variant], false);
 			if (!$variant instanceof CallableParametersAcceptor) {
 				return IsSuperTypeOfResult::createNo([]);
 			}
-			$isSuperType = CallableTypeHelper::isParametersAcceptorSuperTypeOf($this, $variant, $treatMixedAsAny);
+			$isSuperType = CallableTypeHelper::isParametersAcceptorSuperTypeOf($this, $variant, $treatMixedAsAny, !$isBuiltinCallable);
 			if ($variantsResult === null) {
 				$variantsResult = $isSuperType;
 			} else {
@@ -404,6 +405,11 @@ public function getAsserts(): Assertions
 		return Assertions::createEmpty();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 	public function toNumber(): Type
 	{
 		return new ErrorType();

src/Type/CallableTypeHelper.php

@@ -16,6 +16,7 @@ public static function isParametersAcceptorSuperTypeOf(
 		CallableParametersAcceptor $ours,
 		CallableParametersAcceptor $theirs,
 		bool $treatMixedAsAny,
+		bool $strictTypes = true,
 	): IsSuperTypeOfResult
 	{
 		$theirParameters = $theirs->getParameters();
@@ -72,7 +73,7 @@ public static function isParametersAcceptorSuperTypeOf(
 			}
 
 			if ($treatMixedAsAny) {
-				$isSuperType = $theirParameter->getType()->accepts($ourParameterType, true);
+				$isSuperType = $theirParameter->getType()->accepts($ourParameterType, $strictTypes);
 				$isSuperType = new IsSuperTypeOfResult($isSuperType->result, $isSuperType->reasons);
 			} else {
 				$isSuperType = $theirParameter->getType()->isSuperTypeOf($ourParameterType);

src/Type/ClosureType.php

@@ -138,6 +138,11 @@ public function getAsserts(): Assertions
 		return $this->assertions;
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 	/**
 	 * @return array<non-empty-string, TemplateTag>
 	 */

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2741,6 +2741,39 @@ public function testBug12363(): void
 		$this->analyse([__DIR__ . '/data/bug-12363.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.1')]
+	public function testBug11619(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11619.php'], []);
+	}
+
+	#[RequiresPhp('>= 8.1')]
+	public function testBug11619Strict(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11619-strict.php'], []);
+	}
+
+	#[RequiresPhp('>= 8.1')]
+	public function testBug11619Error(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11619-error.php'], [
+			[
+				'Parameter #1 $string1 of function strnatcasecmp expects string, Bug11619Error\Foo given.',
+				32,
+			],
+			[
+				'Parameter #2 $string2 of function strnatcasecmp expects string, Bug11619Error\Foo given.',
+				32,
+			],
+		]);
+	}
+
+	#[RequiresPhp('>= 8.1')]
+	public function testBug11619Typed(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11619-typed.php'], []);
+	}
+
 	public function testBug13247(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-13247.php'], []);

tests/PHPStan/Rules/Functions/data/bug-11619-error.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11619Error;
+
+final class Foo implements \Stringable {
+
+	private function __construct(public readonly string $value) {
+	}
+
+	public static function fromString(string $string): self {
+		return new self($string);
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	public function __toString(): string {
+		return $this->value;
+	}
+
+}
+
+$options = [
+	Foo::fromString('c'),
+	Foo::fromString('b'),
+	Foo::fromString('a'),
+	Foo::fromString('ccc'),
+	Foo::fromString('bcc'),
+];
+
+
+uasort($options, fn($a, $b) => strnatcasecmp($a, $b));
+
+var_export($options);

tests/PHPStan/Rules/Functions/data/bug-11619-strict.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1); // lint >= 8.1
+
+namespace Bug11619Strict;
+
+final class Foo implements \Stringable {
+
+	private function __construct(public readonly string $value) {
+	}
+
+	public static function fromString(string $string): self {
+		return new self($string);
+	}
+
+	public function __toString(): string {
+		return $this->value;
+	}
+
+}
+
+function test(): void
+{
+	$options = [
+		Foo::fromString('c'),
+		Foo::fromString('b'),
+		Foo::fromString('a'),
+	];
+
+	uasort($options, 'strnatcasecmp');
+	usort($options, 'strnatcasecmp');
+}

tests/PHPStan/Rules/Functions/data/bug-11619-typed.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11619Typed;
+
+final class Foo implements \Stringable {
+
+	private function __construct(public readonly string $value) {
+	}
+
+	public static function fromString(string $string): self {
+		return new self($string);
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	public function __toString(): string {
+		return $this->value;
+	}
+
+}
+
+$options = [
+	Foo::fromString('c'),
+	Foo::fromString('b'),
+	Foo::fromString('a'),
+	Foo::fromString('ccc'),
+	Foo::fromString('bcc'),
+];
+
+
+uasort($options, fn(string $a, string $b) => strnatcasecmp($a, $b));
+
+var_export($options);

tests/PHPStan/Rules/Functions/data/bug-11619.php

@@ -0,0 +1,30 @@
+<?php // lint >= 8.1
+
+namespace Bug11619;
+
+final class Foo implements \Stringable {
+
+	private function __construct(public readonly string $value) {
+	}
+
+	public static function fromString(string $string): self {
+		return new self($string);
+	}
+
+	public function __toString(): string {
+		return $this->value;
+	}
+
+}
+
+function test(): void
+{
+	$options = [
+		Foo::fromString('c'),
+		Foo::fromString('b'),
+		Foo::fromString('a'),
+	];
+
+	uasort($options, 'strnatcasecmp');
+	usort($options, 'strnatcasecmp');
+}