Skip to content

make sure LazyTableReference isn't resolved until referenced table has been initialised#758

Closed
dantownsend wants to merge 21 commits intomasterfrom
757-lazy-table-reference-sometimes-fails
Closed

make sure LazyTableReference isn't resolved until referenced table has been initialised#758
dantownsend wants to merge 21 commits intomasterfrom
757-lazy-table-reference-sometimes-fails

Conversation

@dantownsend
Copy link
Copy Markdown
Member

Resolves #757

@dantownsend dantownsend added the bug Something isn't working label Jan 31, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.00%. Comparing base (b13c383) to head (0bd1f12).
⚠️ Report is 247 commits behind head on master.

Files with missing lines Patch % Lines
piccolo/columns/base.py 75.00% 1 Missing ⚠️
piccolo/columns/reference.py 96.77% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   90.91%   87.00%   -3.92%     
==========================================
  Files         109      109              
  Lines        8214     8257      +43     
==========================================
- Hits         7468     7184     -284     
- Misses        746     1073     +327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dantownsend dantownsend mentioned this pull request Jul 26, 2023
@dantownsend
Copy link
Copy Markdown
Member Author

I'll keep this open for now, but improvements were made in #1040, so I'm not sure if this PR is required any more.

@sinisaos
Copy link
Copy Markdown
Member

sinisaos commented Mar 4, 2026

I'm closing this because it seems to be resolved with #1040. Feel free to reopen if necessary.

@sinisaos sinisaos closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LazyTableReference sometimes fails

3 participants