Conversation
| from: aConfiguration. | ||
| ^ configuredCheckers values ]]. | ||
|
|
||
| put: (availableCheckers at: aCheck) new ]. |
There was a problem hiding this comment.
This is correct I configured the checker far too many times.
| MicChecker >> checkProject: aFileReference [ | ||
|
|
||
| | collector | | ||
| results := OrderedCollection new. |
There was a problem hiding this comment.
Can you explain why you need to reinitialize the results?
Because results is already initiliazed in the initialize method.
There was a problem hiding this comment.
I found that In the normal usage through MicAnalysisReportWriter, a new checker instance is created for each check, so the reinitialization is indeed redundant. However, in the tests, the same checker instance is reused multiple times, which requires the reinitialization.
There was a problem hiding this comment.
This is strange because the setUp is creating a new instance each time.
BTW could you split the PR so that we can have a PR for the tools and one for the rest.
I plan also to make the list of checker settable. this way we will be able to write better tests.
Tx.
2 participants
No description provided.