Skip to content

cherry-pick from v8.5.4: MySQL compatibility about decimal insert through jdbc (#22007)#22446

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
ti-chi-bot:cherry-pick-22007-to-master
Feb 14, 2026
Merged

cherry-pick from v8.5.4: MySQL compatibility about decimal insert through jdbc (#22007)#22446
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
ti-chi-bot:cherry-pick-22007-to-master

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #22007

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added area/develop This PR relates to the area of TiDB App development. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. labels Feb 11, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the developer guide by adding a new section on MySQL compatibility, specifically addressing how TiDB handles DECIMAL data insertions when the number of decimal places exceeds the defined scale. It clarifies the behavioral shift in TiDB v8.5.4 to match MySQL's consistent truncation logic, ensuring better compatibility for users.

Highlights

  • Documentation Update: Added a new section to the developer guide detailing MySQL compatibility for DECIMAL data insertion.
  • Behavioral Alignment: Documented the change in TiDB's DECIMAL truncation behavior from v8.5.4, which now aligns with MySQL's approach of automatically truncating extra decimal places regardless of their count.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • develop/dev-guide-sample-application-java-jdbc.md
    • Added a new section titled "MySQL compatibility" to explain TiDB's behavior when inserting DECIMAL values with excessive decimal places, comparing it to MySQL's behavior and detailing changes in TiDB v8.5.4.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a section on MySQL compatibility regarding DECIMAL column insertions. The new content is clear and accurate, but it can be improved for conciseness and readability by reducing repetition, as per the repository's documentation style guide. I've provided a suggestion to make the text more direct and easier to understand.

@qiancai qiancai changed the title Do not merge until v8.5.4: MySQL compatibility about decimal insert through jdbc (#22007) v8.5.4: MySQL compatibility about decimal insert through jdbc (#22007) Feb 14, 2026
@qiancai qiancai changed the title v8.5.4: MySQL compatibility about decimal insert through jdbc (#22007) cherry-pick from v8.5.4: MySQL compatibility about decimal insert through jdbc (#22007) Feb 14, 2026
@qiancai
Copy link
Collaborator

qiancai commented Feb 14, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 14, 2026
@ti-chi-bot ti-chi-bot bot merged commit 0ecfde3 into pingcap:master Feb 14, 2026
10 of 11 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-22007-to-master branch February 14, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants