v8.5.6: DM supports MySQL 8.4#22505
Conversation
Summary of ChangesHello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the DM compatibility catalog to accurately reflect the current support status for MySQL 8.4. The documentation now indicates that MySQL 8.4 is in an 'Experimental' state, providing users with the latest information regarding its integration capabilities with DM. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the compatibility status for MySQL 8.4 with TiDB Data Migration (DM) to 'Experimental'. My review focuses on documentation formatting and consistency. I've identified a minor formatting issue in the markdown table and provided a suggestion to correct it for better readability and to align with the rest of the document.
dm/dm-compatibility-catalog.md
Outdated
| | MySQL 8.0 | GA | Does not support binlog transaction compression [Transaction_payload_event](https://dev.mysql.com/doc/refman/8.0/en/binary-log-transaction-compression.html). | | ||
| | MySQL 8.1 ~ 8.3 | Not tested | | | ||
| | MySQL 8.4 | Incompatible | For more information, see [DM Issue #11020](https://github.com/pingcap/tiflow/issues/11020). | | ||
| | MySQL 8.4 | Experimental| |
There was a problem hiding this comment.
To maintain correct and consistent markdown table formatting, please add spaces around the Experimental value and ensure the row has the correct number of columns by adding a final pipe.
| | MySQL 8.4 | Experimental| | |
| | MySQL 8.4 | Experimental | | |
References
- The repository style guide requires correct formatting and consistency in documentation. This change ensures the markdown table is well-formed and readable, consistent with other entries. (link)
ti-chi-bot
bot
removed
the
missing-translation-status
Oreoxmt
added
do-not-merge/hold
Oreoxmt
changed the title
Oreoxmt
added
translation/done
|
@Oreoxmt: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @alastori @OliverS929 |
|
@Oreoxmt: GitHub didn't allow me to request PR reviews from the following users: OliverS929. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@alastori: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @qiancai |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
In response to a cherrypick label: new pull request created to branch |
5 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
This PR is translated from:
Other reference link(s):
dm: Add MySQL 8.4 info to compatibility catalog #22041
DM: Support MySQL 8.4 tiflow#11020
DM: Support for MySQL 8.4 tiflow#12396
Do your changes match any of the following descriptions?