Skip to content

pdf: remove StickyHeaderTable tags before PDF generation #22970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qiancai wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pdf: remove StickyHeaderTable tags before PDF generation #22970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fcea1d
Update merge_by_toc.py
qiancai May 29, 2026
713c130
resolve comments
qiancai May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions scripts/merge_by_toc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,27 @@ def replace_heading(match):
return replace_heading


# remove <StickyHeaderTable> / </StickyHeaderTable> tags for PDF output
sticky_header_table_pattern = re.compile(r'^\s*</?StickyHeaderTable\s*/?>\s*$')

def remove_sticky_header_table(text):
lines = text.split('\n')
result = []
i = 0
while i < len(lines):
if sticky_header_table_pattern.match(lines[i]):
prev_blank = len(result) > 0 and result[-1].strip() == ''
next_blank = i + 1 < len(lines) and lines[i + 1].strip() == ''
if prev_blank and next_blank:
i += 2
else:
i += 1
else:
result.append(lines[i])
i += 1
return '\n'.join(result)

Comment on lines +235 to +236
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

According to PEP 8, top-level function and class definitions should be surrounded by two blank lines. Currently, there is only one blank line between remove_sticky_header_table and remove_copyable.

Suggested change
return '\n'.join(result)
return '\n'.join(result)
References
  1. PEP 8: Surround top-level function and class definitions with two blank lines. (link)


# remove copyable snippet code
def remove_copyable(match):
return ""
Expand All @@ -233,6 +254,7 @@ def remove_copyable(match):
chapter = replace_variables(chapter, variables)
chapter = replace_link_wrap(chapter, name)
chapter = copyable_snippet_pattern.sub(remove_copyable, chapter)
chapter = remove_sticky_header_table(chapter)
chapter = extract_custom_ids_and_clean(chapter)
chapter = replace_custom_id_links(chapter)
# This block is to filter <CustomContent paltform="xxx"> xxx </CustomContent>
Expand Down