Skip to content

information-schema: fix table name in USER_ATTRIBUTES doc - #23476

Open
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-user-attributes-table-name
Open

information-schema: fix table name in USER_ATTRIBUTES doc#23476
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-user-attributes-table-name

Conversation

@yahonda

@yahonda yahonda commented Aug 10, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The opening sentence of the USER_ATTRIBUTES page referred to itself as "The USER_PRIVILEGES table", a copy-paste error. USER_PRIVILEGES is a different, unrelated INFORMATION_SCHEMA table (columns: GRANTEE, TABLE_CATALOG, PRIVILEGE_TYPE, IS_GRANTABLE) — not the one being documented on this page, which is about user comments/attributes (columns: USER, HOST, ATTRIBUTE, as shown in this same page's own DESC output).

Confirmed against a live TiDB v8.5.7 instance:

mysql> DESC user_attributes;
+-----------+--------------+------+------+---------+-------+
| Field     | Type         | Null | Key  | Default | Extra |
+-----------+--------------+------+------+---------+-------+
| USER      | varchar(32)  | NO   |      | NULL    |       |
| HOST      | varchar(255) | NO   |      | NULL    |       |
| ATTRIBUTE | longtext     | YES  |      | NULL    |       |
+-----------+--------------+------+------+---------+-------+

mysql> desc user_privileges;
+----------------+--------------+------+------+---------+-------+
| Field          | Type         | Null | Key  | Default | Extra |
+----------------+--------------+------+------+---------+-------+
| GRANTEE        | varchar(81)  | YES  |      | NULL    |       |
| TABLE_CATALOG  | varchar(512) | YES  |      | NULL    |       |
| PRIVILEGE_TYPE | varchar(64)  | YES  |      | NULL    |       |
| IS_GRANTABLE   | varchar(3)   | YES  |      | NULL    |       |
+----------------+--------------+------+------+---------+-------+

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

N/A

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected the table description to accurately refer to USER_ATTRIBUTES.

The opening sentence of the USER_ATTRIBUTES page referred to itself as
the USER_PRIVILEGES table, a copy-paste error -- USER_PRIVILEGES is a
different table entirely (GRANTEE/TABLE_CATALOG/PRIVILEGE_TYPE/
IS_GRANTABLE columns), unrelated to user comments/attributes
(USER/HOST/ATTRIBUTE columns, as shown in this same page's own DESC
output and confirmed against a live TiDB v8.5.7 instance).
@ti-chi-bot

ti-chi-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3d67f69d-7b75-4495-a1e6-33d8cc74f88a

📥 Commits

Reviewing files that changed from the base of the PR and between 351d30f and a68aaa8.

📒 Files selected for processing (1)
  • information-schema/information-schema-user-attributes.md

📝 Walkthrough

Walkthrough

The documentation corrects the table name in the USER_ATTRIBUTES description.

Changes

USER_ATTRIBUTES documentation

Layer / File(s) Summary
Correct table reference
information-schema/information-schema-user-attributes.md
The description now identifies USER_ATTRIBUTES as the source of user comments and attributes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documented table-name correction.
Description check ✅ Passed The description explains the change, affected versions, related links status, AI involvement, and applicable change categories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant