[WIP]: add the release notes for v8.5.8 - #23522
Conversation
📝 WalkthroughWalkthroughAdds the TiDB 8.5.8 release notes. The document records release metadata, improvements, and bug fixes across TiDB, TiKV, PD, BR, TiCDC, and TiDB Lightning. ChangesTiDB 8.5.8 release documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🔵 Low · up to The PR adds release notes only, but the current text still has a duplicate component label and an imprecise workload description. These are low-impact documentation and metadata issues with no runtime effect; the PR is mergeable with explicit owner awareness or follow-up to correct them. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@zhangjinpeng87: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
|
@lidezhu: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - Fix multiple issues in TiCDC Kafka sink verification, including unexpected topic creation or other startup-only side effects, skipped Schema Registry checks for existing topics, and incorrect `replication-factor` validation for topics that TiCDC does not create [#5618](https://github.com/pingcap/ticdc/issues/5618) [#5720](https://github.com/pingcap/ticdc/issues/5720) @[3AceShowHand](https://github.com/3AceShowHand) <!-- component: cdc --> <!-- pr: https://github.com/pingcap/ticdc/pull/5811 --> | ||
| - Fix the issue that enabling claim-check causes a TiCDC Kafka sink to create a separate storage client for each encoder, increasing resource usage [#5719](https://github.com/pingcap/ticdc/issues/5719) @[3AceShowHand](https://github.com/3AceShowHand) <!-- component: cdc --> <!-- pr: https://github.com/pingcap/ticdc/pull/5811 --> | ||
| - Fix the issue that TiCDC Kafka sink errors might be inconsistently classified or wrapped, making retry classification and troubleshooting more difficult [#5790](https://github.com/pingcap/ticdc/issues/5790) @[3AceShowHand](https://github.com/3AceShowHand) <!-- component: cdc --> <!-- pr: https://github.com/pingcap/ticdc/pull/5811 --> | ||
| - Fix the issue that TiCDC might spike memory and CPU usage when bulk-creating many idle changefeeds because the coordinator does not honor the configured scheduler concurrency limit [#4831](https://github.com/pingcap/ticdc/issues/4831) @[wlwilliamx](https://github.com/wlwilliamx) <!-- component: cdc --> <!-- pr: https://github.com/pingcap/ticdc/pull/5396 --> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace the ambiguous quantity.
many does not define the workload size, and Vale flagged this wording. Use a more precise phrase.
| - Fix the issue that TiCDC might spike memory and CPU usage when bulk-creating many idle changefeeds because the coordinator does not honor the configured scheduler concurrency limit [#4831](https://github.com/pingcap/ticdc/issues/4831) @[wlwilliamx](https://github.com/wlwilliamx) <!-- component: cdc --> <!-- pr: https://github.com/pingcap/ticdc/pull/5396 --> | |
| - Fix the issue that TiCDC might spike memory and CPU usage when bulk-creating a large number of idle changefeeds because the coordinator does not honor the configured scheduler concurrency limit [`#4831`](https://github.com/pingcap/ticdc/issues/4831) @[wlwilliamx](https://github.com/wlwilliamx) <!-- component: cdc --> <!-- pr: https://github.com/pingcap/ticdc/pull/5396 --> |
As per path instructions: Markdown issues require a GitHub committable suggestion when an exact contiguous replacement is safe.
🧰 Tools
🪛 GitHub Check: vale
[warning] 104-104:
[vale] reported by reviewdog 🐶
[PingCAP.Ambiguous] Consider using a clearer word than 'many' because it may cause confusion.
Raw Output:
{"message":"[PingCAP.Ambiguous] Consider using a clearer word than 'many' because it may cause confusion.","location":{"path":"releases/release-8.5.8.md","range":{"start":{"line":104,"column":88},"end":{"line":104,"column":92}}},"severity":"INFO","code":{"value":"PingCAP.Ambiguous"}}
Sources: Path instructions, Linters/SAST tools
| - Fix the issue that `IMPORT INTO` might report success with inconsistent indexes after a transient conflict-deletion commit error [#69792](https://github.com/pingcap/tidb/issues/69792) @[D3Hunter](https://github.com/D3Hunter) <!-- component: lightning --> <!-- pr: https://github.com/pingcap/tidb/pull/70254 --> | ||
| - Fix the issue that `IMPORT INTO` might fail with the `lock held by current process` error after an import error or retry when local engine files are not cleaned up correctly [#65645](https://github.com/pingcap/tidb/issues/65645) @[D3Hunter](https://github.com/D3Hunter) <!-- component: lightning --> <!-- pr: https://github.com/pingcap/tidb/pull/69478 --> | ||
| - Fix the issue that `IMPORT INTO` silently writes incorrect values for repeated dictionary-encoded Parquet `DECIMAL` columns [#70365](https://github.com/pingcap/tidb/issues/70365) @[joechenrh](https://github.com/joechenrh) <!-- component: lightning --> <!-- pr: https://github.com/pingcap/tidb/pull/70461 --> | ||
| - Fix the issue that `IMPORT INTO` or related local backend ingest tasks might hang when job generation is canceled [#69240](https://github.com/pingcap/tidb/issues/69240) @[D3Hunter](https://github.com/D3Hunter) <!-- component: lightning, dxf, lightning --> <!-- pr: https://github.com/pingcap/tidb/pull/70234 --> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the duplicate component label.
The metadata lists lightning twice. Keep one entry so component metadata remains unambiguous.
| - Fix the issue that `IMPORT INTO` or related local backend ingest tasks might hang when job generation is canceled [#69240](https://github.com/pingcap/tidb/issues/69240) @[D3Hunter](https://github.com/D3Hunter) <!-- component: lightning, dxf, lightning --> <!-- pr: https://github.com/pingcap/tidb/pull/70234 --> | |
| - Fix the issue that `IMPORT INTO` or related local backend ingest tasks might hang when job generation is canceled [`#69240`](https://github.com/pingcap/tidb/issues/69240) @[D3Hunter](https://github.com/D3Hunter) <!-- component: lightning, dxf --> <!-- pr: https://github.com/pingcap/tidb/pull/70234 --> |
As per path instructions: Markdown issues require a GitHub committable suggestion when an exact contiguous replacement is safe.
Source: Path instructions
What is changed, added or deleted? (Required)
As in the title
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit