coordinator: add context to method to prevent resource leak

[3AceShowHand]

What problem does this PR solve?

Issue Number: close #3813

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

[gemini-code-assist]

Summary of Changes

Hello @3AceShowHand, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and resource management of the coordinator component by consistently propagating context.Context through various methods. This change ensures that long-running operations and event handling can be properly cancelled and resources released when the parent context is done, thereby preventing potential resource leaks and improving the overall stability and responsiveness of the system.

Highlights

• Context Propagation: The context.Context parameter has been added to several key methods within the coordinator package, including HandleEvent, checkOnNodeChanged, onMessage, onNodeChanged, onMaintainerBootstrapResponse, handleBootstrapResponses, and finishBootstrap in controller.go, and its usage in coordinator.go.
• Improved Error Handling: Replaced ctx.Err() with context.Cause(ctx) in collectMetrics (controller.go), runHandleEvent (coordinator.go), and checkStaleCheckpointTs (coordinator.go) to provide more specific error information when a context is cancelled or times out.
• Resource Leak Prevention: Internal calls within finishBootstrap that previously used context.Background() now correctly propagate the provided ctx, ensuring that operations like GetAllChangefeeds and StopChangefeed respect the cancellation signals of the parent context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request focuses on propagating context.Context through the coordinator's methods to prevent resource leaks and improve cancellation handling. The changes are generally well-executed, replacing context.Background() with the propagated context in many places. Additionally, the switch from ctx.Err() to context.Cause(ctx) is a good improvement for better error reporting on context cancellation.

I've found one instance where context.Background() is still being used instead of the passed-in context, which I've commented on. Addressing this will make the context propagation more consistent and robust.

[3AceShowHand]

/test all

[3AceShowHand]

/test all

[3AceShowHand]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hongyunyan,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-12-26 08:55:01.538809607 +0000 UTC m=+2413646.352587169: ☑️ agreed by wk989898.
• 2025-12-29 03:53:33.315886632 +0000 UTC m=+2654758.129664204: ☑️ agreed by hongyunyan.