metrics,grafana: add ticdc_arch to build info (#4266)#5329
Conversation
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test all |
This is an automated cherry-pick of #4266
What problem does this PR solve?
Issue Number: close #4265
What is changed and how it works?
ticdc_archlabel toticdc_server_build_info.ticdc_arch="newarch"when TiCDC runs in new architecture mode.ticdc_arch. If an instance does not exposeticdc_server_build_info(old arch), the panel falls back toticdc_server_etcd_health_check_duration_countand showsticdc_arch="oldarch".Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. The change adds one constant label to an existing build info gauge metric and only affects dashboard queries.
Do you need to update user documentation, design documentation or monitoring documentation?
Monitoring dashboard is updated in this PR.
Release note
Summary by CodeRabbit
New Features
Monitoring