Skip to content

metrics,grafana: add ticdc_arch to build info (#4266)#5329

Open
ti-chi-bot wants to merge 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-4266-to-release-8.5
Open

metrics,grafana: add ticdc_arch to build info (#4266)#5329
ti-chi-bot wants to merge 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-4266-to-release-8.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #4266

What problem does this PR solve?

Issue Number: close #4265

What is changed and how it works?

  • Add ticdc_arch label to ticdc_server_build_info.
  • Set ticdc_arch="newarch" when TiCDC runs in new architecture mode.
  • Update the Grafana "Build Info" panel to show ticdc_arch. If an instance does not expose ticdc_server_build_info (old arch), the panel falls back to ticdc_server_etcd_health_check_duration_count and shows ticdc_arch="oldarch".

Check List

Tests

  • Manual test
CleanShot 2026-02-24 at 19 23 10@2x

Questions

Will it cause performance regression or break compatibility?

No. The change adds one constant label to an existing build info gauge metric and only affects dashboard queries.

Do you need to update user documentation, design documentation or monitoring documentation?

Monitoring dashboard is updated in this PR.

Release note

Expose TiCDC architecture mode (newarch/oldarch) in build info metric and dashboard.

Summary by CodeRabbit

  • New Features

    • Added an architecture dimension to build info metrics so builds can be identified and monitored by architecture.
  • Monitoring

    • Grafana dashboards updated to surface the new architecture field in Build Info panels, adjust field ordering, and include fallback aggregation to ensure architecture visibility across instances.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jun 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7b265267-fdbe-455f-a329-fdfd5f703466

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wlwilliamx

Copy link
Copy Markdown
Collaborator

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants