Render top referrers and search terms within the context of sources tabs#6204
Merged
Render top referrers and search terms within the context of sources tabs#6204
Conversation
zoldar
force-pushed
the
sources-referrers-google-preserve-other-tabs
branch
from
a93484e to
29b31d4
Compare
|
zoldar
force-pushed
the
sources-referrers-google-preserve-other-tabs
branch
2 times, most recently
from
7c644e9 to
6c0059b
Compare
zoldar
force-pushed
the
sources-referrers-google-preserve-other-tabs
branch
2 times, most recently
from
da45ddd to
d71b64f
Compare
zoldar
force-pushed
the
sources-referrers-google-preserve-other-tabs
branch
from
134a3dd to
28f418a
Compare
|
RobertJoonas
approved these changes
Apr 1, 2026
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for further extending the E2E tests! 🙌
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR reorganizes sources breakdown tabs so that "Top referrers" and "Search terms" (Google Search keywords) are always rendered in place of "Sources" instead of replacing the breakdown tile completely with a single tab.
I took this opportunity to add e2e coverage for search terms breakdown using mocked API response (which got updated to reflect actual real payload by the way).
Tests
Dark mode