Allow revenue metrics to be queried with session dimensions

[ukutaht]

Changes

Allows revenue metrics to be queries with session dimensions. Prepares for refactoring entry page breakdown to APIv2 code.

Tests

• Automated tests have been added

Changelog

• Entry has been added to changelog

Documentation

• Docs have been updated

Dark mode

• This PR does not change the UI

[ukutaht]

This is needed not for the dashboard but for API. In the dashboard we always add a [:is_not, "visit:entry_page", ""] filter to queries so checking filters is enough. We can't expect that there's always a filter present in API queries.

[zoldar]

Would it make sense to extend the check the same way sessions_join_events? ?

[zoldar]

Would it make sense to extend the check the same way sessions_join_events? ?

[ukutaht]

Would it make sense to extend the check the same way sessions_join_events? ?

@zoldar no, the line on

analytics/lib/plausible/stats/table_decider.ex

Line 56 in 16eb2be

not empty?(session_only_metrics) and not empty?(event_only_dimensions) ->

guards against session metrics being requested for event dimensions so adding the same extension to sessions_join_events would be a no-op.

I had to change events_join_sessions? because we now allow revenue metrics (limited set of event metrics) being requested with session dimensions like entry_page or source.

[zoldar]

@ukutaht got it. If that would ever change and there would be similar exclusions the other way around, the logic would have to be altered anyway and doing that up front would only muddle it up.

[RobertJoonas]

Thanks for this @ukutaht! Looks good to me! 👍