fix: move pytest-timeout to dev-dependency#415
Merged
emilykl merged 1 commit intoplotly:masterfrom Mar 24, 2026
Merged
Conversation
Contributor
Author
|
Let me put the mention @ayjayt. |
|
Hey, I came in looking to log the same issue. What's blocking this fix? Can I help? |
Contributor
Author
|
Let me kindly ask @ayjayt to review this again. 🙏 |
|
I am also interested to get this dependency cleaned up, thanks! |
|
also noticed this one recently wondering why pytest was suddenly included in my docker image |
Contributor
Author
|
Thank you so much @emilykl for your review! I'd like to ask the dev team to release a new version of kaleido including this patch as well. 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#397 started to use
pytest-timeoutbut it seems that the package uses only for testging. As reported in #414, now kaleido is shipped with pytest related packages. I think these are not intended and users would not need them at runtime.