-
Notifications
You must be signed in to change notification settings - Fork 27
ci: remove test-connect jobs #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
I think those are different (the second and I think third bullets on #649 (comment)). I don't think we should remove them (yet) but they also don't have the same problems that these do. They're using a nightly docker image of Connect (https://github.com/posit-dev/rsconnect-python/blob/main/docker-compose.yml#L4) but don't have the same source dependency that there is here. |
| cd integration-testing | ||
| docker compose pull connect | ||
| docker compose up -d connect | ||
| just ../test/connect-rsconnect-python/test/rsconnect-python/test-rsconnect-python-repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this merges, we can tidy up this justfile in connect and at least remove this target, which nothing else calls. Probably worth doing an audit there of any other stuff, like in the docker compose setup, to see if there's more that we can prune.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rsconnect-repo hits a few other things in connect, including in the docker-compose.yml. I think that's the thread to tug on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connect ticket for this follow up work: https://github.com/posit-dev/connect/issues/34626
We'll get most of this by adding some better coverage against the nightly public docker image (#649). In the meantime, worst case is someone merges something bad, the Connect nightly tests fail, and we have to circle back and fix. |
nealrichardson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a step in the right direction, thank you for taking this on
Intent
Remove
test-connectjobs from here and instead run tests against dev Connect by specifying thersconnect-pythonbranch in the workflow dispatch forrsconnect-python-tests-at-nightjob in Connect. (https://github.com/posit-dev/connect/actions/workflows/rsconnect-python.yml)My remaining concern around this revolves around the tests against Connect being an important part of the testing for
rsconnect-pythonand while it works fine to trigger them on the Connect side it is a bit of a clunky workflow and nothing is preventing someone from accidentally merging a PR without first running those.TODO: should(no)test-rsconnectinmain.ymlbe removed as well?Related to #649
Approach
deploy_tests.ymlcan be fully removed as it only includedtest-connectjobs.Checklist
secrets.CONNECT_PATpost merge