Skip to content

Conversation

@joshyam-k
Copy link
Contributor

@joshyam-k joshyam-k commented Nov 13, 2025

Intent

Remove test-connect jobs from here and instead run tests against dev Connect by specifying the rsconnect-python branch in the workflow dispatch for rsconnect-python-tests-at-night job in Connect. (https://github.com/posit-dev/connect/actions/workflows/rsconnect-python.yml)

My remaining concern around this revolves around the tests against Connect being an important part of the testing for rsconnect-python and while it works fine to trigger them on the Connect side it is a bit of a clunky workflow and nothing is preventing someone from accidentally merging a PR without first running those.

TODO: should test-rsconnect in main.yml be removed as well? (no)

Related to #649

Approach

deploy_tests.yml can be fully removed as it only included test-connect jobs.

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.
  • remove secrets.CONNECT_PAT post merge

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-17 16:00 UTC

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5260 4004 76% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 0b7bdf0 by action🐍

@nealrichardson
Copy link
Contributor

TODO: should test-rsconnect in main.yml be removed as well?

I think those are different (the second and I think third bullets on #649 (comment)). I don't think we should remove them (yet) but they also don't have the same problems that these do. They're using a nightly docker image of Connect (https://github.com/posit-dev/rsconnect-python/blob/main/docker-compose.yml#L4) but don't have the same source dependency that there is here.

cd integration-testing
docker compose pull connect
docker compose up -d connect
just ../test/connect-rsconnect-python/test/rsconnect-python/test-rsconnect-python-repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this merges, we can tidy up this justfile in connect and at least remove this target, which nothing else calls. Probably worth doing an audit there of any other stuff, like in the docker compose setup, to see if there's more that we can prune.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsconnect-repo hits a few other things in connect, including in the docker-compose.yml. I think that's the thread to tug on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect ticket for this follow up work: https://github.com/posit-dev/connect/issues/34626

@joshyam-k joshyam-k marked this pull request as ready for review November 14, 2025 15:58
@nealrichardson
Copy link
Contributor

My remaining concern around this revolves around the tests against Connect being an important part of the testing for rsconnect-python and while it works fine to trigger them on the Connect side it is a bit of a clunky workflow and nothing is preventing someone from accidentally merging a PR without first running those.

We'll get most of this by adding some better coverage against the nightly public docker image (#649). In the meantime, worst case is someone merges something bad, the Connect nightly tests fail, and we have to circle back and fix.

Copy link
Contributor

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a step in the right direction, thank you for taking this on

@joshyam-k joshyam-k merged commit 4a259b4 into main Nov 17, 2025
13 checks passed
@joshyam-k joshyam-k deleted the jy/remove-test-connect branch November 17, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants