Skip to content

fix: PostgresNode::kill uses self._os_ops.get_platform() instead os.name #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 1 commit into from
Jun 4, 2026
Merged

fix: PostgresNode::kill uses self._os_ops.get_platform() instead os.name #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from __future__ import annotations

import logging
import os
import signal
import subprocess

Expand Down Expand Up @@ -1215,7 +1214,10 @@ def kill(self, someone=None):

assert x.node_status == NodeStatus.Running
assert type(x.pid) is int
sig = signal.SIGKILL if os.name != 'nt' else signal.SIGBREAK
if self._os_ops.get_platform() == "win32":
sig = 21 # signal.SIGBREAK
else:
sig = signal.SIGKILL
if someone is None:
self._os_ops.kill(x.pid, sig)
self._manually_started_pm_pid = None
Expand Down