Various adapters: consolidate devicepixelratio usage into approximation #14192

patmmccann · 2025-11-20T22:17:17Z

No description provided.

Removed direct devicePixelRatio retrieval and validation.

github-actions · 2025-11-20T22:19:05Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/datablocksBidAdapter.js has 85 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 40 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 31 duplicated lines with modules/mediaforceBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

…odule 51Degrees RTD Provider: remove device pixel ratio helper

github-actions · 2025-11-20T22:30:07Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/datablocksBidAdapter.js has 85 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 40 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 31 duplicated lines with modules/mediaforceBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

patmmccann · 2025-11-24T19:24:58Z

duplication solved here #14186

…nmsws

github-actions · 2025-11-24T22:21:12Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/datablocksBidAdapter.js has 85 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 40 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 31 duplicated lines with modules/mediaforceBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2025-11-25T17:33:21Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/datablocksBidAdapter.js has 85 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 40 duplicated lines with modules/mediaforceBidAdapter.js
modules/datablocksBidAdapter.js has 31 duplicated lines with modules/mediaforceBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

dgirardi

I pushed an update about the code itself, but I'm not convinced the approximation works:

the fallback using screen.height / innerHeight is way off for me (dpr = 1, approx ~= 5.5)
screen.width / innerWidth kinda works (1 vs 1.02) but only if the browser window is maximized. Resizing it changes the approximated value significantly while devicePixelRatio remains constant
I know very little about devicePixelRatio but I suspect it would behave differently on mobile.

dgirardi · 2025-11-25T17:43:44Z

I missed some unit tests that would need to be updated to work with this, but I'll wait to see what we want to do before addressing them

…nmsws

dgirardi · 2025-12-03T18:33:52Z

I updated this to keep the centralization but just return devicePixelRatio, pending separate work to gate it (and others) behind publisher config

libraries/devicePixelRatio/devicePixelRatio.js

+
+export function getDevicePixelRatio(win) {
+  try {
+    return getFallbackWindow(win).devicePixelRatio;


modules/apstreamBidAdapter.js


 function getScreenParams() {
-  return `${window.screen.width}x${window.screen.height}@${window.devicePixelRatio}`;
+  return `${window.screen.width}x${window.screen.height}@${getDevicePixelRatio(window)}`;


modules/datablocksBidAdapter.js

      'wxo': win.pageXOffset,
      'wyo': win.pageYOffset,
-      'wpr': win.devicePixelRatio,
+      'wpr': getDevicePixelRatio(win),


modules/greenbidsBidAdapter.js

      deviceWidth: screen.width,
      deviceHeight: screen.height,
-      devicePixelRatio: topWindow.devicePixelRatio,
+      devicePixelRatio: getDevicePixelRatio(topWindow),


modules/gumgumBidAdapter.js

    tpl: mosttopURL,
    ce: storage.cookiesAreEnabled(),
-    dpr: topWindow.devicePixelRatio || 1,
+    dpr: getDevicePixelRatio(topWindow),


modules/hypelabBidAdapter.js

    const uuid = uids[0] ? uids[0] : generateTemporaryUUID();
    const floor = getBidFloor(request, request.sizes || []);
-    const dpr = typeof window !== 'undefined' ? window.devicePixelRatio : 1;
+    const dpr = typeof window !== 'undefined' ? getDevicePixelRatio(window) : 1;


modules/oguryBidAdapter.js

    const req = buildRequest(imps, bidderRequest, context);
    req.tmax = DEFAULT_TIMEOUT;
-    deepSetValue(req, 'device.pxratio', window.devicePixelRatio);
+    deepSetValue(req, 'device.pxratio', getDevicePixelRatio(getWindowContext()));


modules/sspBCBidAdapter.js

    'CH-Downlink': connection.downlink,
    'CH-DeviceMemory': null,
-    'CH-Dpr': W.devicePixelRatio,
+    'CH-Dpr': getDevicePixelRatio(W),


modules/teadsBidAdapter.js

      deviceWidth: screen.width,
      deviceHeight: screen.height,
-      devicePixelRatio: topWindow.devicePixelRatio,
+      devicePixelRatio: getDevicePixelRatio(topWindow),


libraries/devicePixelRatio/devicePixelRatio.js

+
+export function getDevicePixelRatio(win) {
+  try {
+    return getFallbackWindow(win).devicePixelRatio;


modules/apstreamBidAdapter.js


 function getScreenParams() {
-  return `${window.screen.width}x${window.screen.height}@${window.devicePixelRatio}`;
+  return `${window.screen.width}x${window.screen.height}@${getDevicePixelRatio(window)}`;


modules/greenbidsBidAdapter.js

      deviceWidth: screen.width,
      deviceHeight: screen.height,
-      devicePixelRatio: topWindow.devicePixelRatio,
+      devicePixelRatio: getDevicePixelRatio(topWindow),


modules/gumgumBidAdapter.js

    tpl: mosttopURL,
    ce: storage.cookiesAreEnabled(),
-    dpr: topWindow.devicePixelRatio || 1,
+    dpr: getDevicePixelRatio(topWindow),


modules/hypelabBidAdapter.js

    const uuid = uids[0] ? uids[0] : generateTemporaryUUID();
    const floor = getBidFloor(request, request.sizes || []);
-    const dpr = typeof window !== 'undefined' ? window.devicePixelRatio : 1;
+    const dpr = typeof window !== 'undefined' ? getDevicePixelRatio(window) : 1;


modules/oguryBidAdapter.js

    const req = buildRequest(imps, bidderRequest, context);
    req.tmax = DEFAULT_TIMEOUT;
-    deepSetValue(req, 'device.pxratio', window.devicePixelRatio);
+    deepSetValue(req, 'device.pxratio', getDevicePixelRatio(getWindowContext()));


modules/sspBCBidAdapter.js

    'CH-Downlink': connection.downlink,
    'CH-DeviceMemory': null,
-    'CH-Dpr': W.devicePixelRatio,
+    'CH-Dpr': getDevicePixelRatio(W),


modules/teadsBidAdapter.js

      deviceWidth: screen.width,
      deviceHeight: screen.height,
-      devicePixelRatio: topWindow.devicePixelRatio,
+      devicePixelRatio: getDevicePixelRatio(topWindow),


patmmccann · 2025-12-03T19:00:47Z

marking as on hold for next pmc, we didnt cover today

patmmccann and others added 2 commits November 20, 2025 17:13

Libraries: simplify device pixel ratio derivation

31ce882

Refactor getDevicePixelRatio function

bd4d675

Removed direct devicePixelRatio retrieval and validation.

review-assignment-bot bot requested review from dgirardi and ncolletti November 20, 2025 22:19

patmmccann and others added 2 commits November 20, 2025 17:24

Remove 51Degrees module device pixel ratio updates

7a46e25

Merge pull request #330 from patmmccann/codex/remove-changes-to-51d-m…

9a3ed35

…odule 51Degrees RTD Provider: remove device pixel ratio helper

patmmccann marked this pull request as ready for review November 24, 2025 22:19

Merge branch 'master' into codex/consolidate-devicepixelratio-usage-f…

f998add

…nmsws

patmmccann changed the title ~~Various adapters: consolidate devicepixelratio usage~~ Various adapters: consolidate devicepixelratio usage into approximation Nov 24, 2025

cleanup

5960cb2

dgirardi requested changes Nov 25, 2025

View reviewed changes

Merge branch 'master' into codex/consolidate-devicepixelratio-usage-f…

9d1efcd

…nmsws

patmmccann added the pmc-review label Dec 1, 2025

patmmccann and others added 3 commits December 2, 2025 10:56

Merge branch 'master' into codex/consolidate-devicepixelratio-usage-f…

f52e157

…nmsws

fix tests

2d1e9cb

more test fixes

a40ef50

github-advanced-security bot found potential problems Dec 3, 2025

View reviewed changes

fix lint

62b09d0

patmmccann removed the request for review from ncolletti December 3, 2025 19:00

patmmccann added the on hold label Dec 3, 2025

Various adapters: consolidate devicepixelratio usage into approximation #14192

Are you sure you want to change the base?

Various adapters: consolidate devicepixelratio usage into approximation #14192

Uh oh!

Conversation

patmmccann commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

patmmccann commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

dgirardi left a comment

Choose a reason for hiding this comment

Uh oh!

dgirardi commented Nov 25, 2025

Uh oh!

dgirardi commented Dec 3, 2025

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

patmmccann commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants