Fix LineDeliveryNoteReferencedDocument missing LineID#110
Open
martaprilmay wants to merge 2 commits intopretix:masterfrom
Open
Fix LineDeliveryNoteReferencedDocument missing LineID#110martaprilmay wants to merge 2 commits intopretix:masterfrom
martaprilmay wants to merge 2 commits intopretix:masterfrom
Conversation
also removes tmp test_delivery_note_line_id_error (LineDeliveryNoteReferencedDocument.LineID is handled by test_sample_roundtrip)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
LineDeliveryNoteReferencedDocumentis missing theline_idfield.All other line-level referenced document classes in the same file include:
line_id = StringField(NS_RAM, "LineID", required=False, profile=COMFORT)This includes:
LineUltimateCustomerOrderReferencedDocumentLineBuyerOrderReferencedDocumentLineContractReferencedDocumentLineDespatchAdviceReferencedDocumentLineReceivingAdviceReferencedDocumentLineAdditionalReferencedDocumentThe docs also suggest that
EXTENDEDprofileDeliveryNoteReferencedDocumenthasLineIDelement (this is under SpecifiedLineTradeDelivery Grouping of delivery details on line level BT-129-00):Solution:
Add
line_idtoLineDeliveryNoteReferencedDocument