Skip to content

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Nov 18, 2025

Closes https://github.com/github/primer/issues/6142

Removes the variant prop and replaces it with Tooltip specific CSS. Primary was handled previously.

Depends on https://github.com/github/github-ui/pull/7169 merging to unblock test failures.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: 9b11466

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Updated the version of @primer/react to major and removed the variant prop from the KeybindingHint Chord component.
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 18, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

.sort(compareLowercaseKeys)

export const Chord = ({keys, format = 'condensed', variant = 'normal', size = 'normal'}: KeybindingHintProps) => (
export const Chord = ({keys, format = 'condensed', size = 'normal'}: KeybindingHintProps) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the "variant" prop in KeyBindingHint will be a no-op? Not sure we should remove this without a major 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did add a major changeset as it is breaking. FWIW I'm removing calls from dotcom in this PR but probably safe to put this in the next major anyway! https://github.com/github/github-ui/pull/7169

@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants