fix(AnchoredOverlay): use position-visibility:always to keep overlay visible when anchor is hidden in Firefox - #8294
Open
waterWang wants to merge 1 commit into
Conversation
…visible when anchor is hidden in Firefox Firefox defaults position-visibility to 'anchors-visible', which hides the anchored overlay when its anchor element scrolls off-screen. This causes anchored overlays like ActionMenu, SelectPanel, and Tooltip to disappear in Firefox when the trigger element is scrolled out of view. Setting position-visibility: always ensures the overlay stays visible even when its anchor is hidden, matching Chrome's behavior. Closes primer#8247
|
Member
|
@waterWang, LGTM! Do you mind adding a changeset? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Firefox defaults
position-visibilitytoanchors-visible, which hides CSS-anchored elements when their anchor scrolls off-screen. This causes anchored overlays (ActionMenu, SelectPanel, Tooltip, etc.) to disappear in Firefox when the trigger element is scrolled out of view, while Chrome keeps them visible.Setting
position-visibility: alwayson.AnchoredOverlayensures the overlay stays visible even when its anchor is hidden, matching Chrome behavior.Changes
packages/react/src/AnchoredOverlay/AnchoredOverlay.module.css:position-visibility: alwaysTest Plan
Closes #8247