Skip to content

Migrate interactive roots to mergeProps - #8299

Draft
joshblack wants to merge 2 commits into
migrate/merge-props-batch-06from
migrate/merge-props-batch-07
Draft

Migrate interactive roots to mergeProps#8299
joshblack wants to merge 2 commits into
migrate/merge-props-batch-06from
migrate/merge-props-batch-07

Conversation

@joshblack

@joshblack joshblack commented Aug 12, 2026

Copy link
Copy Markdown
Member

Part of the ADR-025 prop merging migration.

This PR updates a group of lower-volume selection and interactive-data components to merge component-authored and consumer-authored props through mergeProps. The changes preserve existing refs, event ordering, consumer precedence, class names, and accessibility behavior while removing 43 findings from the migration report.

Changelog

New

  • Add stricter Checkbox coverage to confirm consumer handlers run once per interaction.

Changed

  • Update Autocomplete, Checkbox, DataTable, Details, FilteredActionList, Overlay, Pagination, Popover, ProgressBar, ScrollableRegion, Select, SelectPanel, Timeline, and ToggleSwitch roots to use the ADR-025 prop-merging convention.
  • Preserve explicit consumer undefined precedence for Autocomplete overlay focus behavior.
  • Preserve consumer polymorphic overrides for SelectPanel secondary links.

Removed

  • None.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

This is a behavior-preserving migration and does not change the public API, so no changeset is required.

Testing & Reviewing

  • Review event ordering and cancellation for Autocomplete, Checkbox, Overlay, and SelectPanel.
  • Review controlled attributes and consumer precedence across the migrated roots.
  • Confirm the mergeProps migration report decreases from 144 findings across 66 files to 101 findings across 48 files.
  • Targeted component tests and the @primer/react type-check pass.

@changeset-bot

changeset-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0fe27ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@joshblack
joshblack force-pushed the migrate/merge-props-batch-07 branch from d8f07f6 to d465c44 Compare August 12, 2026 16:24
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8299 August 12, 2026 16:28 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8299 August 12, 2026 16:38 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Aug 13, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 84a0d8ca-13d3-4cb2-ab24-18fa2d9a8a14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 84a0d8ca-13d3-4cb2-ab24-18fa2d9a8a14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant