Fix asset file fetch error in Directus extension#131
Merged
Conversation
The AssetsService.getAsset() method was being called with an empty object {} as the transformation parameter. This caused resolvePreset to attempt destructuring transformationParams as undefined, resulting in "Cannot read properties of undefined (reading 'transforms')". Since no transformations are needed for the base64 conversion, the parameter is now omitted.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the "Cannot read properties of undefined (reading 'transforms')" error that occurred when fetching files during asset generation.
The issue was in the
getFileAsBase64()function which was callingassetsService.getAsset(fileId, {})with an empty transformation object. This caused Directus' internalresolvePreset()to attempt destructuringtransformationParamsas undefined, leading to the error.Since no image transformations are needed for base64 conversion, the transformation parameter is now omitted.
Test plan
🤖 Generated with Claude Code