Update error handling documentation to include new pulp exceptions #7230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aKlimau
force-pushed
the
docs-error-handling-improvements
branch
2 times, most recently
from
1130f96 to
fe29e7d
Compare
mdellweg
reviewed
Jan 21, 2026
|
|
||
| Listed below are all available PulpExceptions, sorted by error code. | ||
|
|
||
| ### InternalErrorException (PLP0000) |
Member
There was a problem hiding this comment.
For easier lookup, make the PLPxxxx align in the same column by moving them to the front.
Member
There was a problem hiding this comment.
Also this reference list should really move over to the users section.
aKlimau
force-pushed
the
docs-error-handling-improvements
branch
2 times, most recently
from
643edfd to
782d3ec
Compare
mdellweg
reviewed
Jan 22, 2026
aKlimau
force-pushed
the
docs-error-handling-improvements
branch
from
782d3ec to
c042afd
Compare
jobselko
reviewed
Jan 26, 2026
|
|
||
| **Usage in code:** | ||
| ```python | ||
| # In pulpcore/tasking/tasks.py:87 |
Contributor
There was a problem hiding this comment.
Specific line numbers will get outdated quickly imo. Maybe it would be better not to mention them?
Contributor
Author
There was a problem hiding this comment.
Should I just leave just a file path in this case or is it better to not mention location within files at all?
Contributor
There was a problem hiding this comment.
Up to you, I do not have a preference
Assisted by Claude Code
aKlimau
force-pushed
the
docs-error-handling-improvements
branch
from
c042afd to
b9241e5
Compare
dralley
approved these changes
Jan 27, 2026
Contributor
|
Looks generally good, any nitpicks can be addressed later IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.