Add a pull request template #7231
Draft
+28
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a checklist for contributors
gerrod3
reviewed
Jan 20, 2026
mdellweg
reviewed
Jan 21, 2026
Member
mdellweg
left a comment
mdellweg
left a comment
There was a problem hiding this comment.
With mkdocs, there's a way to move all the links into a references section in the end, if you want to make the bulk "more readable".
Comment on lines
+19
to
+20
| 4. If the PR is a simple feature or a bugfix, please [`rebase and squash`](site:pulpcore/docs/dev/guides/git/#markdown-header-rebasing-and-squashing) to a single commit. If the PR | ||
| is a complex feature, make sure that all commits are cleanly separated and have meaningful commit messages. |
Member
There was a problem hiding this comment.
Suggested change
| 4. If the PR is a simple feature or a bugfix, please [`rebase and squash`](site:pulpcore/docs/dev/guides/git/#markdown-header-rebasing-and-squashing) to a single commit. If the PR | |
| is a complex feature, make sure that all commits are cleanly separated and have meaningful commit messages. | |
| 4. If the PR is a simple feature or a bugfix, please [`rebase and squash`](site:pulpcore/docs/dev/guides/git/#markdown-header-rebasing-and-squashing) to a single commit. | |
| If the PR is a complex feature, make sure that all commits are cleanly separated and have meaningful commit messages. |
| {doc}`file an issue</bugs-features>`. | ||
| 4. If the PR is a simple feature or a bugfix, please [`rebase and squash`](site:pulpcore/docs/dev/guides/git/#markdown-header-rebasing-and-squashing) to a single commit. If the PR | ||
| is a complex feature, make sure that all commits are cleanly separated and have meaningful commit messages. | ||
| 5. Make sure you tag commits with `closes #IssueNumber` or `ref #IssueNumber` when working on a tracked issue |
Member
There was a problem hiding this comment.
Suggested change
| 5. Make sure you tag commits with `closes #IssueNumber` or `ref #IssueNumber` when working on a tracked issue | |
| 5. Make sure you tag commits with `closes #IssueNumber` or `ref #IssueNumber` when working on a tracked issue. |
| 4. If the PR is a simple feature or a bugfix, please [`rebase and squash`](site:pulpcore/docs/dev/guides/git/#markdown-header-rebasing-and-squashing) to a single commit. If the PR | ||
| is a complex feature, make sure that all commits are cleanly separated and have meaningful commit messages. | ||
| 5. Make sure you tag commits with `closes #IssueNumber` or `ref #IssueNumber` when working on a tracked issue | ||
| 6. If AI was used, please make sure you are following the [Pulp policy on AI Usage](site:help/more/governance/ai_policy/) |
Member
There was a problem hiding this comment.
Suggested change
| 6. If AI was used, please make sure you are following the [Pulp policy on AI Usage](site:help/more/governance/ai_policy/) | |
| 6. If AI was used, please make sure you are following the [Pulp policy on AI Usage](site:help/more/governance/ai_policy/). |
We don't use "please" anywhere else.
Comment on lines
+24
to
+25
| 8. If the change requires a corresponding change in pulp-cli, open a PR against the pulp-cli or docs, or | ||
| `file an issue`. |
Member
There was a problem hiding this comment.
Suggested change
| 8. If the change requires a corresponding change in pulp-cli, open a PR against the pulp-cli or docs, or | |
| `file an issue`. | |
| 8. If the change requires a corresponding change in pulp-cli, open a PR against the pulp-cli. |
Let's not make it sound as if you could just push out the work to someone else. If it's "required" it "should be done".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a checklist for contributors
📜 Checklist