pbio/drv/display, pybricks.parameters: Improve conversion from HSV to pixel value. #431
+61
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Dec 3, 2025
pybricks/parameters/pb_type_image.c
Outdated
Comment on lines
47
to
49
| uint16_t h = pbio_int_math_bind(hsv->h, 0, 359); | ||
| uint8_t s = pbio_int_math_bind(hsv->s, 0, 100); | ||
| uint8_t v = pbio_int_math_bind(hsv->v, 0, 100); |
Member
There was a problem hiding this comment.
The range of these values should already be guaranteed. If not, we could have problems elsewhere as well. Maybe just an assert() here instead to catch problems in debug builds?
Contributor
Author
There was a problem hiding this comment.
There is at least Color.NONE which is defined with a negative V:
const pb_type_Color_obj_t pb_Color_NONE_obj = {
{&pb_type_Color},
.hsv = {0, 0, -40}
};
Contributor
Author
There was a problem hiding this comment.
OK, I made the change.
… pixel value.
Use a mapping trying to match the real pixel color, select the nearest
pixel value according to the input color.
Small test program:
from pybricks.hubs import ThisHub
from pybricks.parameters import Color
from pybricks.tools import wait
hub = ThisHub()
i = hub.screen
for y in range(i.height):
for x in range(i.width):
i.draw_pixel(x, y, Color(0, y * 100 / (i.height - 1), x * 100 / (i.width - 1)))
wait(50000)
Closes: pybricks/support#2442
dlech
approved these changes
Dec 3, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a mapping trying to match the real pixel color, select the nearest pixel value according to the input color.
Small test program:
Closes: pybricks/support#2442