fix: handle None module in module_available#11358
Open
jaythehardcoder wants to merge 1 commit into
Open
Conversation
module_available(None) crashes with: AttributeError: 'NoneType' object has no attribute 'startswith' Add an early return of False when module is None, and a regression test covering None, valid modules, and minversion checks. Closes pydata#11344 Co-authored-by: Claude <noreply@anthropic.com>
Illviljan
requested changes
May 27, 2026
Contributor
Illviljan
left a comment
There was a problem hiding this comment.
How do we get a None as input? This function does not allow anything else than str.
Is this an actual problem in xarray?
Author
|
It happens when external tooling (like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #11344.
module_available(None)crashes withAttributeError: 'NoneType' object has no attribute 'startswith'during version checks (e.g., in the rain-to-flood toolkit).This adds an early return of
Falsewhenmodule is None, and a regression test covering None input, valid modules, and minversion checks.Checklist
whats-new.rstapi.rstAI Disclosure
Tools: Hermes Agent
Test Plan
uv run pytest xarray/tests/test_namedarray.py::test_module_available -v-> 1 passeduv run pytest xarray/tests/test_namedarray.py -q-> all existing tests still pass