get_page_images(): only return images actually referenced by the given page#4961
Open
andreasntr wants to merge 2 commits intopymupdf:mainfrom
Open
get_page_images(): only return images actually referenced by the given page#4961andreasntr wants to merge 2 commits intopymupdf:mainfrom
andreasntr wants to merge 2 commits intopymupdf:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per
Document.get_page_images()docs:This fix allows getting only the images actually referenced by the given page by comparing xrefs returned by
Page.get_image_info(xrefs=True).The list of images xrefs for each page is saved at
Documentcreation time, filtering is performed only when invokingget_page_imageson the document.Request
I was able to write this code because i used this kind of workaround in a project of mine base on pymudf, however I'm not able to fully test it because the process of creating the test environment is not clear (
pyproject.tomlis empty for example). I'll be happy to test it when instructions are provided