fix: Handle warning filename when the file and the CWD are on different Windows drives#148
Merged
Merged
Conversation
edgarrmondragon
force-pushed
the
fix/windows-handle-different-drives
branch
from
642bc23 to
36f47d2
Compare
…nt Windows drives Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
force-pushed
the
fix/windows-handle-different-drives
branch
from
36f47d2 to
a5094cb
Compare
henryiii
approved these changes
Jun 19, 2026
Contributor
|
(Looks safe and similar to before AFAICT) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
badb1c5 (#138) refactored the warning path computation to call
compute_path(os.path.relpath(warning_message.filename)), butos.path.relpath()raisesValueErroronWindows when the file and the CWD are on different drive letters.
The original code had
contextlib.suppress(ValueError)for this case, which was lost in the refactor.Closes #147