cache: keep cache keys within the cache directory - #14884
Merged
RonnyPfannschmidt merged 1 commit intoAug 18, 2026
Conversation
RonnyPfannschmidt
added a commit
to RonnyPfannschmidt/pytest
that referenced
this pull request
Aug 14, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
psf-chronographer
Bot
added
the
bot:chronographer:provided
Keys were joined onto the cache directory without normalization, so an absolute or ".."-containing key resolved somewhere else entirely, and ``set()`` created the missing parents there. Normalize the joined path and check containment instead. ``mkdir()`` only rejected path separators, which ".." passes as a single part, and ``--cache-show`` globbed with the same lack of normalization. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
RonnyPfannschmidt
force-pushed
the
cache-key-containment
branch
from
August 14, 2026 20:13
b38e870 to
0d582dd
Compare
RonnyPfannschmidt
marked this pull request as ready for review
August 14, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cachejoined keys onto the cache directory without normalizing them, so a keythat was absolute or contained
..resolved outside it —set()then alsocreated the missing parent directories at that location.
_getvaluepath()normalizes the joined path and checks containment, soget()/set()reject escaping keys while a..that cancels out within thevalues directory still works.
mkdir()used the same check; it previously only rejected path separators,which
..passes as a single part.--cache-showglobs are filtered the same way —rglob()follows..segments in the pattern.
Note
Path.is_absolute()is not sufficient on Windows: a rooted-but-drivelesskey like
/xreportsFalseyet still replaces the base injoinpath().Normalizing the joined path covers that without enumerating path flavours.