Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1513.change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The `attrs.validators.disabled()` contextmanager can now be nested.
4 changes: 3 additions & 1 deletion src/attr/validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,14 @@ def disabled():
This context manager is not thread-safe!

.. versionadded:: 21.3.0
.. versionchanged:: 26.1.0 The contextmanager is nestable.
"""
prev = get_run_validators()
set_run_validators(False)
try:
yield
finally:
set_run_validators(True)
set_run_validators(prev)


@attrs(repr=False, slots=True, unsafe_hash=True)
Expand Down
16 changes: 16 additions & 0 deletions tests/test_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,22 @@ def test_disabled_ctx_with_errors(self):

assert _config._run_validators is True

def test_disabled_ctx_nested(self):
"""
Nested contextmanagers restore correct state.
"""
assert _config._run_validators is True

with validator_module.disabled():
assert _config._run_validators is False

with validator_module.disabled():
assert _config._run_validators is False

assert _config._run_validators is False

assert _config._run_validators is True


class TestInstanceOf:
"""
Expand Down
Loading