Fix pendulum.parse('now', tz='...') ignoring the time zone#701
Merged
Secrus merged 1 commit intopython-pendulum:masterfrom Apr 24, 2025
Merged
Fix pendulum.parse('now', tz='...') ignoring the time zone#701Secrus merged 1 commit intopython-pendulum:masterfrom
Secrus merged 1 commit intopython-pendulum:masterfrom
Conversation
CodSpeed Performance ReportMerging #701 will not alter performanceComparing Summary
|
84d8c3d to
6c8a5cc
Compare
8d5cbef to
3313f1b
Compare
Contributor
Author
|
@edgarrmondragon Anything else for me to do on this? |
Contributor
I'll preface saying I'm not a maintainer of this repo, so my approval is only nominal 🙂. This LGTM, there's a Rust linting error but I don't know if it's related to changes in this PR. |
Collaborator
|
Hi. Sorry for the delays, we are digging ourselves out of the pile of code debt. Could you please rebase your changes with the master branch so we can review and merge them? |
3313f1b to
305f80f
Compare
Contributor
Author
|
@Secrus rebased on latest master |
Secrus
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Previously, using "now" with
pendulum.parseshort-circuited all other parsing logic (expected), including the time zone (not expected).Example using the latest release:
The same example after this PR: