Fix typo in variable annotation from _hour to _hours#815
Merged
Secrus merged 1 commit intopython-pendulum:masterfrom Mar 30, 2025
Merged
Fix typo in variable annotation from _hour to _hours#815Secrus merged 1 commit intopython-pendulum:masterfrom
Secrus merged 1 commit intopython-pendulum:masterfrom
Conversation
Secrus
approved these changes
Nov 21, 2024
CodSpeed Performance ReportMerging #815 will not alter performanceComparing Summary
|
ashb
approved these changes
Jan 13, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Nothing will break by not having this fix I've I'm reading the code right, but this is now correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've corrected a minor typo in the variable name within
parsing/iso8601.py, changing_hourto_hoursto avoid unused annotations. No related issues were found/open regarding this typo.This update doesn't impact other parts of the codebase as confirmed by local testing and existing tests where applicable.
Pull Request Check List